Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in total_volatile_organic_compounds_concentration_measurement namespace in esp_matter_attribute.cpp (CON-1133) #911

Closed
kibergus opened this issue Apr 28, 2024 · 4 comments

Comments

@kibergus
Copy link

The header and other locations use plural compounds in the namespace name. But .cpp has the functions defined in a namespace with a singular compound. As a result attempting to define tvoc sensor leads to undefined symbols during linking.

--- a/components/esp_matter/esp_matter_attribute.cpp
+++ b/components/esp_matter/esp_matter_attribute.cpp
@@ -2754,7 +2754,7 @@ attribute_t *create_level_value(cluster_t *cluster, uint8_t value)
 } /* attribute */
 } /* radon_concentration_measurement */
 
-namespace total_volatile_organic_compound_concentration_measurement {
+namespace total_volatile_organic_compounds_concentration_measurement {
 namespace attribute {
 attribute_t *create_measured_value(cluster_t *cluster, nullable<float> value)
 {
@@ -2823,7 +2823,7 @@ attribute_t *create_level_value(cluster_t *cluster, uint8_t value)
 }
 
 } /* attribute */
-} /* total_volatile_organic_compound_concentration_measurement */
+} /* total_volatile_organic_compounds_concentration_measurement */
 
 namespace operational_state {
 namespace attribute {

@github-actions github-actions bot changed the title Typo in total_volatile_organic_compounds_concentration_measurement namespace in esp_matter_attribute.cpp Typo in total_volatile_organic_compounds_concentration_measurement namespace in esp_matter_attribute.cpp (CON-1133) Apr 28, 2024
@jadhavrohit924
Copy link
Contributor

@kibergus Thanks for reporting. If you can, please raise PR with the fix otherwise we will fix it soon.

kibergus added a commit to kibergus/SenseCAP_Indicator_ESP32 that referenced this issue May 6, 2024
I needed to delete and add again the device to HA for it to see new sensors.

NOTE: espressif/esp-matter#911 needs to be fixed for the code to compile.
NOTE: Home assistant matter integration lacks bindings for tVOC so the value will not be visible in the UI.
@kibergus
Copy link
Author

kibergus commented May 6, 2024

Here is a pull request: #918

@dhrishi
Copy link
Collaborator

dhrishi commented May 15, 2024

@kibergus Thanks for the PR. We will get it merged soon

@dhrishi
Copy link
Collaborator

dhrishi commented May 15, 2024

Merged with c9cae5a

@dhrishi dhrishi closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants