Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiling Layout stopped working on some windows after upgrade to Plasma 5.27 #213

Open
clupasq opened this issue Feb 22, 2023 · 8 comments
Open
Labels
bug Something isn't working

Comments

@clupasq
Copy link

clupasq commented Feb 22, 2023

Symptom

After upgrading to KDE 5.27, many windows are not affected by Krohnkite.

How to Reproduce

  1. Update to KDE Plasma 5.27.0
  2. Open a the system settings window, or a Konsole terminal
  3. Note that these are not resized as the current tiling settings require: for me, Konsole opens full screen and the system settings are in Floating mode.
  4. Other windows (ex: Brave browser) obey the tiling layout just fine. If only Brave windows are open on a desktop, all seems well. Opening a Konsole terminal makes the terminal full screen, and the Brave window half screen (obeying tiling).

Expected behavior

I expect all windows to be affected by my current tiling settings (except the ones specifically blacklisted in the Krohnkite settings, like Spectacle for example).

Environment

  • Distro: Fedora 37
  • KWin version: 5.27.0
  • Krohnkite version: v0.8.2 (75f65da)
  • List of KWin scripts in use: [Krohnkite]

Notes

@clupasq clupasq added the bug Something isn't working label Feb 22, 2023
@absorb-it
Copy link

Same here, not working on 5.27.2, was working on 5.26.5 before.

  • Distro: Gentoo
  • KWin version: 5.27.2
  • Krohnkite version: v0.8.2 (75f65da)
  • List of KWin scripts in use: [Krohnkite] [SelectiveVirtualDesktops]

@absorb-it
Copy link

implemented some temporary fix (ugly, works-for-me) and added as pull-request. Building from https://github.com/absorb-it/krohnkite with this change works now on kwin 5.27

Be aware that I have no idea what the modified variables are used for and what might be affected additionally by this change - it just prevents running into this bug. Additional fixes might be required.

Best regards, Rene

@clupasq
Copy link
Author

clupasq commented Mar 5, 2023

Thank you, @absorb-it !

I confirm that your fix works for me as well. 👍

@ghost
Copy link

ghost commented May 2, 2023

tried to compile it but got this error instead:

tsc
make: tsc: No such file or directory
make: *** [Makefile:71: krohnkite.js] Error 127

what causes this problem?

@clupasq
Copy link
Author

clupasq commented May 2, 2023

tried to compile it but got this error instead:

tsc
make: tsc: No such file or directory
make: *** [Makefile:71: krohnkite.js] Error 127

what causes this problem?

It appears that you don't have the TypeScript compiler installed.

Try to install it with:

npm i --location=global typescript

@ghost
Copy link

ghost commented May 2, 2023

#It appears that you don't have the TypeScript compiler installed.
turns out it was not installed yet, thank you so much! :D

@orange-toothbrush
Copy link

Can confirm this fix works. Thanks @absorb-it

@Matt-Kou
Copy link

This is not working for me on 5.27.4. Just to make sure that I am using it correctly:

  1. click on the window to tile
  2. meta + T
  3. select the zone for the window

Nothing happens after I select the directed zone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants