Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-async relations are not validated correctly #44

Open
bladams opened this issue Oct 7, 2016 · 3 comments
Open

Non-async relations are not validated correctly #44

bladams opened this issue Oct 7, 2016 · 3 comments
Assignees
Labels

Comments

@bladams
Copy link
Contributor

bladams commented Oct 7, 2016

Validations for related models are not run when the relationship is defined like DS.hasMany('related-model', {async: false})

I believe this is a regression introduced in this commit. I think in this case the related objects are not wrapped in a proxy so the content property is undefined.

I am currently using ember-data 2.8.1

@esbanarango esbanarango added the bug label Oct 7, 2016
@esbanarango esbanarango self-assigned this Oct 7, 2016
@rogeraraujo90
Copy link

I still see this issue on Ember 4.8. Is this repo being maintained?

@esbanarango
Copy link
Owner

@rogeraraujo90 it is. I can check this issue next weekend

@rogeraraujo90
Copy link

@esbanarango Thanks! I'm using the custom validator as a workaround. Very helpful!

I don't have free time to investigate the fix by myself until my next product release but let me know if I can help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants