Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests to v1-production-notifier-configs.s3.amazonaws.com - set remote_config_host to nil #1479

Open
espen opened this issue Aug 27, 2020 · 8 comments

Comments

@espen
Copy link
Contributor

espen commented Aug 27, 2020

After upgrading to Airbrake v5 I am seeing requests to v1-production-notifier-configs.s3.amazonaws.com. This is a default setting in Airbrake to use for remote configuration. See airbrake/airbrake-ruby#611

As there is no need for remote configuration from Airbrake.io this setting should be disabled. I tried setting it to nil and after some basic testing it seems to not do the request.

Should we add config.remote_config_host = nil as a default setting in https://github.com/errbit/errbit/blob/master/app/views/apps/_configuration_instructions.html.haml ?

@stevecrozz
Copy link
Member

That sounds good to me. I haven't used the airbrake v5 gem, but this looks like the right thing to do.

@espen
Copy link
Contributor Author

espen commented Aug 27, 2020

There is a __remote_configuration but it is for private use only. https://github.com/airbrake/airbrake-ruby/blob/96cd0a629310a8411413cb5a89b4f70baa952918/lib/airbrake-ruby/config.rb#L135

@kyrylo
Copy link

kyrylo commented Oct 15, 2020

__remote_configuration was used in release candidates of airbrake v5 but in the stable version it doesn't exist anymore.

@javierav
Copy link

Using airbrake-ruby 5.1.1, if you set nil to remote_config_host you get the following error:

undefined method `chomp' for nil:NilClass
**Airbrake: applying remote settings: {}

Possible solutions:

  1. Implement a config option to disable remote config. Should be implemented by airbrake guys.
  2. Implement the remote config endpoint in Errbit and configure the client with remote_config_host pointing to our errbit.

@espen
Copy link
Contributor Author

espen commented Nov 26, 2020

Yeah I already mentioned this to Airbrake. They really need to disable this feature, it has privacy issues too.

@javierav
Copy link

I send a PR with a fix for this issue: airbrake/airbrake-ruby#632

@javierav
Copy link

Meantime, I have applied this patch to my app:

class Airbrake::Config::Processor
  def process_remote_configuration
    return unless @config.remote_config_host

    super
  end
end

Airbrake.configure do |c|
  # ...
  c.remote_config_host = nil
end

@2called-chaos
Copy link
Member

For airbrake-ruby since v5.2.0 (airbrake is at v11 so I guess you were referring to airbrake-ruby v5) the config option is c.remote_config = false (ref)

Anyone mad if I add this to the wiki? https://github.com/2called-chaos/errbit/wiki/Draft:-Airbrake-v11-config-example-for-Errbit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants