Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting errors from search results doesn't work #1473

Open
simX opened this issue May 4, 2020 · 1 comment
Open

Deleting errors from search results doesn't work #1473

simX opened this issue May 4, 2020 · 1 comment

Comments

@simX
Copy link

simX commented May 4, 2020

Environment

  • Errbit version: 0.8.0
  • OS: Fedora 28

Description of the problem:

When trying to delete errors in Errbit, the only place you can do so is from the list of errors. However, if you perform a search through the list of issues, you cannot correctly delete errors if search results are showing: you'll get a 404 error page.

Steps to reproduce:

  1. Log in to Errbit.
  2. Click on one of your apps to see the list of errors.
  3. Click the checkbox to the left of one of the error groupings, and then scroll down to the bottom of the page and press the "Delete" button. Note that this will succeed.
  4. Type a search query in the "Search for issues" box at the top of the page, and press return
  5. Again, click the checkbox to the left of one of the error groupings in the search results, and scroll down to the bottom of the page and press the "Delete" button. This will fail.

Observed Results:

  • When trying to delete from search results, you get redirected to a page that says: "The page you were looking for doesn't exist. You may have mistyped the address or the page may have moved." The URL in the address bar is https://errbit.ifixit.com/problems/search .
  • If you try to delete from the list of error groupings without a search query, deleting works as expected.

Expected Results:

  • I expect to be able to delete errors from search results.
@2called-chaos
Copy link
Member

Can you still reproduce the issue? I can't reproduce it but I also don't see any commit since then that would have fixed something like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants