Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rails 5 migration or maybe even 6 now? #1413

Open
darix opened this issue Jan 21, 2019 · 8 comments
Open

rails 5 migration or maybe even 6 now? #1413

darix opened this issue Jan 21, 2019 · 8 comments

Comments

@darix
Copy link

darix commented Jan 21, 2019

what is holding this back?

@stevecrozz
Copy link
Member

Nothing that I know of. I think it'll take someone to give it a try and see if there are any blockers.

@darix
Copy link
Author

darix commented Jan 21, 2019

Well rails 4.2.11 was the last security fix for 4.2. question is if one wants to jump to rails 6 beta directly and skip rails 5.

@rud
Copy link
Contributor

rud commented Jan 23, 2019 via email

@hamadata
Copy link
Contributor

Though what I did was just updated Gemfile to 5.2, I found these are the blockers:

  1. hoptoad_notifier gem uses obsoleted syntax app.config.middleware.use "HoptoadNotifier::Rack".
  2. ActionController::RedirectBackError is obsoleted in Rails 5.1.
  3. request methods (e.g. :post) in controller specs requires params: {} style arguments.

@stevecrozz
Copy link
Member

Thanks for the research @hamadata . Can all three of these changes be made prior to an upgrade?

@hamadata
Copy link
Contributor

hamadata commented Oct 22, 2019

  1. This is a problem of gem hoptoad_notifier, I need to fork the repository and change the line.
- app.config.middleware.use "HoptoadNotifier::Rack"
+ app.config.middleware.use HoptoadNotifier::Rack

Though it supresses the fatal error after upgrading to Rails5, but I do not know if it works.

  1. No, I could not find the method in Rails4.

https://blog.bigbinary.com/2016/02/29/rails-5-improves-redirect_to_back-with-redirect-back.html

  1. No, I could not find backported feature in Rails4.

https://til.hashrocket.com/posts/e7a2880383-rails-5-deprecation-warning-for-controller-tests
(This document says it became deprecated in Rails5.0, and obsoleted in Rails5.1 or 5.2)

@hamadata
Copy link
Contributor

hamadata commented Nov 6, 2019

Deprecated usage in controller tests can be sovled with this gem.

https://github.com/r7kamura/rails_kwargs_testing

@alexanderadam
Copy link

I guess a Rails upgrade would also make it easier to use things like webpacker and therefore maybe to get a new UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants