Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status Report #114

Open
eric-bixby opened this issue Nov 27, 2022 · 6 comments
Open

Status Report #114

eric-bixby opened this issue Nov 27, 2022 · 6 comments
Assignees
Labels
Priority: 2-High Serious problem that could block progress Status: Pending The issue has been assigned but is not currently being worked on Type: Question/Comment The issue is a question or comment

Comments

@eric-bixby
Copy link
Owner

eric-bixby commented Nov 27, 2022

Update for 11/26/2022:

I just wanted to give a quick status report on the state of this project. Yes, there hasn't been much activity, but the project is not abandoned. I've been working on stuff "behind the scenes". I reloaded the OS on my development machine and reinstalled everything from scratch. I'm going to do the development for this project 100% in a container and I'm going to segment the dev-env for all my projects for better dependency management. I customized my terminal (got to make things look nice) and experimented with customizing Neovim as an IDE (but I haven't given up on VSCode).
Anyway, now that I got that out of the way, I can start doing some coding again. My goal is to have at least the first beta of the configure-folders update by the end of the year so we can start beta testing it. Don't count on a lot of updates/fixes, but that one is my highest priority.

@eric-bixby eric-bixby self-assigned this Nov 27, 2022
@eric-bixby eric-bixby added Type: Question/Comment The issue is a question or comment Status: Pending The issue has been assigned but is not currently being worked on Priority: 1-Critical This problem will block progress Priority: 2-High Serious problem that could block progress and removed Priority: 1-Critical This problem will block progress labels Nov 27, 2022
@eric-bixby eric-bixby pinned this issue Nov 27, 2022
@eric-bixby
Copy link
Owner Author

Update for 12/3/2022:

  • Split-up docker process. "docker-build.sh" still does everything, but now "docker-xpi.sh" builds the xpi file without requiring the docker image to be rebuilt. Using docker's "bind mount" feature speeds this up.
  • The node stuff for preferences has old dependencies, so I'm thinking of dumping that and re-writing everything in vanilla javascript, but that is a significant undertaking. I think I will push that out to a future version.
  • For the configure-folders update, people might want a migration option, but that is going to have all kinds of potential problems. Therefore, everyone should save their folder settings, then manually re-apply them.

@eric-bixby eric-bixby changed the title Status Report for 11/26/2022 Status Report Dec 4, 2022
@eric-bixby
Copy link
Owner Author

eric-bixby commented Dec 13, 2022

Update for W/E 12/11/2022:

  • I think I'll make this status a weekly thing.
  • I added ESLint to package.json, but after re-enabling, I realized I had forgotten many findings.
  • As a convenience, most of the code was previously in a single file, so I split it into one class per file.
  • However, I had a hybrid of classes and functions, so I started doing refactoring, but it's going to take at least one more week to get it back to a runnable state again. Got to take a step back before you can move forward.
  • I think after this reorganization/cleanup it will make maintenance easier.

@eric-bixby
Copy link
Owner Author

Update for W/E 12/18/2022:

  • Unfortunately, I didn't get to work on this project this week. However, while working on my fork of a youtube-downloader, I picked up a potential improvement of using docker-compose.yml. When you do "docker compose up", docker will only build the image if needed. Also, you can include the volume mounts (-v) inside the docker-compose.yml rather than using command-line arguments in a script. Not really a big improvement. I just thought it was clever how docker handles this because it is more portable. I probably won't bother.
  • Anyway, my youtube-downloader fork is working, so hopefully, more updates next week.

@eric-bixby
Copy link
Owner Author

Update for W/E 2/5/2023:

  • Sorry, I got distracted with life stuff (holidays, sick, busy, lazy, etc.)
  • Since I got the linter hooked up, I decided to refactor AutoSortBookmarks.js (one big file) into smaller files.
  • I ran into circular dependencies and that's where I took a break (I know how to deal with this in Java, but JavaScript requires a different approach).
  • I know I need to make AsbPrefs.js a singleton.
  • However, my current blocker is that Annotations.js has a circular dependency with AsbPrefs.js. I may need to combine them into one class.

@eric-bixby
Copy link
Owner Author

FYI... here's the latest es-lint report, just to show you where I'm at in the refactoring process:

/Users/ericbixby/git/auto-sort-bookmarks-webext/src/AsbPrefs.js
111:5 error 'Sorter' is not defined no-undef
169:11 error 'Annotations' is not defined no-undef
170:11 error 'Annotations' is not defined no-undef
172:11 error 'Annotations' is not defined no-undef
177:11 error 'Annotations' is not defined no-undef
179:11 error 'Annotations' is not defined no-undef

/Users/ericbixby/git/auto-sort-bookmarks-webext/src/Bookmark.js
72:18 error 'AsbPrefs' is not defined no-undef

/Users/ericbixby/git/auto-sort-bookmarks-webext/src/ChangeHandler.js
88:7 error 'AsbPrefs' is not defined no-undef

/Users/ericbixby/git/auto-sort-bookmarks-webext/src/Comparator.js
64:9 error Assignment to property of function parameter 'bookmark1' no-param-reassign
64:28 error 'AsbUtil' is not defined no-undef
65:9 error Assignment to property of function parameter 'bookmark2' no-param-reassign
65:28 error 'AsbUtil' is not defined no-undef
78:9 error Assignment to property of function parameter 'bookmark1' no-param-reassign
79:9 error Assignment to property of function parameter 'bookmark2' no-param-reassign
89:9 error 'Sorter' is not defined no-undef
96:9 error 'Sorter' is not defined no-undef
103:11 error 'Sorter' is not defined no-undef
105:44 error 'Sorter' is not defined no-undef
107:21 error 'Sorter' is not defined no-undef
108:23 error 'Sorter' is not defined no-undef
111:15 error 'Sorter' is not defined no-undef
118:22 error 'Sorter' is not defined no-undef
119:23 error 'Sorter' is not defined no-undef
120:11 error 'Sorter' is not defined no-undef
127:14 error 'Sorter' is not defined no-undef
128:7 error 'Sorter' is not defined no-undef
132:11 error 'Sorter' is not defined no-undef
139:13 error 'Sorter' is not defined no-undef
144:13 error 'Sorter' is not defined no-undef
147:23 error 'Sorter' is not defined no-undef
148:25 error 'Sorter' is not defined no-undef
151:17 error 'Sorter' is not defined no-undef
158:24 error 'Sorter' is not defined no-undef
159:25 error 'Sorter' is not defined no-undef
160:13 error 'Sorter' is not defined no-undef
179:9 error 'Sorter' is not defined no-undef
181:16 error 'Sorter' is not defined no-undef
182:9 error 'Sorter' is not defined no-undef
186:36 error 'Folder' is not defined no-undef
186:67 error 'Folder' is not defined no-undef
187:35 error 'Sorter' is not defined no-undef
189:27 error 'Sorter' is not defined no-undef
190:29 error 'Sorter' is not defined no-undef
193:21 error 'Sorter' is not defined no-undef
199:26 error 'Sorter' is not defined no-undef
200:27 error 'Sorter' is not defined no-undef
201:15 error 'Sorter' is not defined no-undef
210:36 error 'Folder' is not defined no-undef
210:67 error 'Folder' is not defined no-undef

/Users/ericbixby/git/auto-sort-bookmarks-webext/src/Folder.js
40:18 error 'AsbPrefs' is not defined no-undef
50:7 error 'Annotations' is not defined no-undef
51:7 error 'Annotations' is not defined no-undef
64:24 error 'AsbPrefs' is not defined no-undef

/Users/ericbixby/git/auto-sort-bookmarks-webext/src/FolderUtil.js
115:18 error 'Annotations' is not defined no-undef
154:25 error 'Annotations' is not defined no-undef
155:36 error 'Annotations' is not defined no-undef

/Users/ericbixby/git/auto-sort-bookmarks-webext/src/Sorter.js
99:7 error 'Annotations' is not defined no-undef
224:9 error 'AsbPref' is not defined no-undef
251:30 error 'AsbPref' is not defined no-undef

✖ 59 problems (59 errors, 0 warnings)

@eric-bixby
Copy link
Owner Author

I will try using my GitHub Blog more, so here's the latest status. Also, I'm going to start using branches, so I'll announce on my blog when there's a new version to try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 2-High Serious problem that could block progress Status: Pending The issue has been assigned but is not currently being worked on Type: Question/Comment The issue is a question or comment
Projects
None yet
Development

No branches or pull requests

1 participant