Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: dark mode switch should switch theme ? #3306

Open
grandinj opened this issue Jan 30, 2024 · 0 comments
Open

[Feature Request]: dark mode switch should switch theme ? #3306

grandinj opened this issue Jan 30, 2024 · 0 comments
Assignees
Labels

Comments

@grandinj
Copy link
Contributor

Describe your idea in details

Actual problem: dark mode switch happens, but then I have to manually switch from theme Atom One Light to Atom One Dark (this is on macOS, but I assume similar happens on other platforms)

So I'm not sure what a good solution would look like.
Possibly ignoring the dark mode switch?
Or making it tied to the theme?
Or picking an alternate theme automatically?
Or having a separate setting for the theme to use in dark mode?

Hmmm, the last one feels easiest to me, and most likely to be correct in the face of people using custom themes and the like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants