Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check full SEED ID when comparing picks and waveforms #481

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

calum-chamberlain
Copy link
Member

@calum-chamberlain calum-chamberlain commented Dec 9, 2021

What does this PR do?

Clean take-over from #391

Uses full SEED information (adds network and location) when comparing e.g. pick.waveform_id and tr.stats in a number of functions. Mostly importantly template_gen, but may also include mag_calc and others.

Why was it initiated? Any relevant Issues?

#388

In situations where the desired template or trace contains unique picks with the same Station and Channel, but different location and/or Network codes (e.g. separate sensors in one borehole), current behavior does not differentiate between them.

Assorted to-dos:

  • utils.correlate funcs all return cccs, no_chans, and chans. chans only includes station.channel, which then gets passed to Detection objects. Allow for full seed chans in Detection
  • Track down all the possible effects of using a full seed id chans attribute for Detection objects...could touch quite a lot...
  • Lag calc UsedChannel only uses station.channel. Allow for full seed option.
  • Add depreciation warnings
  • Add docs "Help" page for adding full SEED IDs to Pick objects and link from depreciation warning.

PR Checklist

  • develop base branch selected?
  • This PR is not directly related to an existing issue (which has no PR yet).
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGES.md.
  • First time contributors have added your name to CONTRIBUTORS.md.

@calum-chamberlain
Copy link
Member Author

I think I captured all the relevant changes from #391 - @cjhopp let me know if you spot anything that is missing. Otherwise I will chug on with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check full SEED id of picks against Trace header information
2 participants