Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to resolve $t from vue global properties (#4244) #4256

Merged
merged 3 commits into from May 23, 2024
Merged

Try to resolve $t from vue global properties (#4244) #4256

merged 3 commits into from May 23, 2024

Conversation

Fsss126
Copy link
Contributor

@Fsss126 Fsss126 commented May 6, 2024 •
edited

closes #4244

Description

Implemented feature and updated docs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@Fsss126 Fsss126 changed the title Try to resolve $t from vue global properties #4244 Try to resolve $t from vue global properties (closes #4244) May 6, 2024
@Fsss126 Fsss126 changed the title Try to resolve $t from vue global properties (closes #4244) Try to resolve $t from vue global properties (#4244) May 6, 2024
m0ksem
m0ksem approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, resolve conflicts and we're good to go.

packages/docs/page-config/services/i18n/code/vue-i18n-runtime.ts Outdated Show resolved Hide resolved
packages/docs/page-config/services/i18n/index.ts Outdated Show resolved Hide resolved
@Fsss126 Fsss126 force-pushed the resolve-vue-i18n-translations branch from f42d3e2 to 5b11bd3 Compare May 8, 2024 21:24
@m0ksem m0ksem merged commit 083a39c into epicmaxco:develop May 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0ksem m0ksem m0ksem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(i18n): try to resolve $t from vue global properties
2 participants
@Fsss126 @m0ksem