Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color css variables must be rendered on app root element, not body #4233

Open
m0ksem opened this issue Apr 18, 2024 · 1 comment · May be fixed by #4272
Open

Color css variables must be rendered on app root element, not body #4233

m0ksem opened this issue Apr 18, 2024 · 1 comment · May be fixed by #4272
Assignees
@Fsss126
Labels
BUG Something isn't working

Comments

@m0ksem
Copy link
Contributor

m0ksem commented Apr 18, 2024

I'm using few vue apps on page and both use createVuestic(). Adding styles to body redefine one of the app styles.
@m0ksem m0ksem added the BUG Something isn't working label Apr 18, 2024
@m0ksem
Copy link
Contributor Author

m0ksem commented Apr 24, 2024

To make sure we don't overflow #app styles with extra CSS styles, we can add id to appRoot, like va-${uid} and generate styles for this class.

Fsss126 added a commit to Fsss126/vuestic-ui that referenced this issue May 15, 2024
@Fsss126
Color css variables must be rendered on app root element, not body (e…
718ae5c 
…picmaxco#4233)
@Fsss126 Fsss126 linked a pull request May 15, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fsss126 Fsss126

Labels
BUG Something isn't working
Projects
Vuestic Sprint (7 September - 21 September)
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Color css variables must be rendered on app root element, not body (#4233) Fsss126/vuestic-ui
2 participants
@m0ksem @Fsss126