Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VaAvatar deforms non-square images #4232

Open
bagrovYKT opened this issue Apr 18, 2024 · 0 comments
Open

VaAvatar deforms non-square images #4232

bagrovYKT opened this issue Apr 18, 2024 · 0 comments
Labels
BUG Something isn't working

Comments

@bagrovYKT
Copy link

bagrovYKT commented Apr 18, 2024

Vuestic-ui version: 1.9.8

Description

VaAvatar is currently generate an img tag, which is sensitive to aspect ratio of the source image. So, when it's not 1:1, it is impossible to use VaAvatar component because it deforms image.
However, there is a best-practice for this case to use background-image style property with background-size: cover, background-position: center center instead of img tag. So, i think VaAvatar component should be refactored for properly displayed non-square images.

Best regards to all the contribute team!

@bagrovYKT bagrovYKT added the BUG Something isn't working label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Development

No branches or pull requests

1 participant