Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Family should inherit global font in case there is no Source Sans font installed by default #4218

Open
2 tasks
m0ksem opened this issue Apr 8, 2024 · 1 comment
Assignees
Labels
BUG Something isn't working d1: super easy Task for newbies. Players take half normal damage from monsters and the environment. good first issue Right issue if you're new to vuestic v2: nice to have This will make Vuestic feel better

Comments

@m0ksem
Copy link
Contributor

m0ksem commented Apr 8, 2024

In case if user want to install a different font we probably can react on it without any additional configuration from user.

Right now, user must set --va-font-familly css variable if Source Sans Pro is not installed.

:root {
  --va-font-family: Inter;
}

We can change --va-font-family default value to Source Sand Pro, inherit - I think what it must do is to use Source Sand Pro by default, but in case if font is not available, we need to inherit font from page. User still able to override font familly, but by default we will inherit it from body (most likely from body, if font wasn't overridden somewhere else).

I think it is much more human solution than setting to sans-serif if font is not installed.

More context: #4213

In this task:

  • We need to update css variable default value in essential.scss
  • Make sure I'm correct and it is a good solution
@m0ksem m0ksem added BUG Something isn't working good first issue Right issue if you're new to vuestic d1: super easy Task for newbies. Players take half normal damage from monsters and the environment. v2: nice to have This will make Vuestic feel better labels Apr 8, 2024
@shuvrojit
Copy link

Hey, assign me. I will do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working d1: super easy Task for newbies. Players take half normal damage from monsters and the environment. good first issue Right issue if you're new to vuestic v2: nice to have This will make Vuestic feel better
Development

No branches or pull requests

2 participants