Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VaSelect: hard to customize select options #4064

Open
m0ksem opened this issue Dec 4, 2023 · 0 comments · May be fixed by #4097
Open

VaSelect: hard to customize select options #4064

m0ksem opened this issue Dec 4, 2023 · 0 comments · May be fixed by #4097
Labels
BUG Something isn't working d3: medium No cheats. Monsters a bit faster. v4: must have This is something really user want to have

Comments

@m0ksem
Copy link
Contributor

m0ksem commented Dec 4, 2023

Example:
image

We should have one slot to customize option:
image

And it also should reflect how option is displayed when selected in input field.
For some reason, user need to manually add @click="selectOption". I'd expect just change visual and option to work, but there is nothing happening on click without adding listener manually.

We're also losing default option styles.

I think we need something like option-content slot, which will be placed in SelectOption instead of text. So there is working keyboard navigation, hover effect, etc. But option can have additional icons, avatar, etc.

Right now, using option slot breaks keyboard navigation completely.

@m0ksem m0ksem added BUG Something isn't working d3: medium No cheats. Monsters a bit faster. v4: must have This is something really user want to have labels Dec 4, 2023
@Roman4437 Roman4437 linked a pull request Dec 16, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working d3: medium No cheats. Monsters a bit faster. v4: must have This is something really user want to have
Development

Successfully merging a pull request may close this issue.

1 participant