Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shot.sequences should be Shot.sequence #71

Open
3 tasks
eoyilmaz opened this issue Dec 8, 2022 · 0 comments
Open
3 tasks

Shot.sequences should be Shot.sequence #71

eoyilmaz opened this issue Dec 8, 2022 · 0 comments
Assignees
@eoyilmaz
Milestone
1.0.0

Comments

@eoyilmaz
Copy link
Owner

eoyilmaz commented Dec 8, 2022 •
edited

Over the years, we saw that the idea of a shot being a part of two sequences has not been realized even once. So it was super unnecessary. Revert that change so that Shot.sequence is a many-to-one relation from Shot to Sequence.

The change is apparently made in c21c411

  • Update tests
  • Revert the Shot.sequence attribute to this state,
  • Genereate proper Alembic migration script
@eoyilmaz eoyilmaz added this to the 1.0.0 milestone Dec 8, 2022
@eoyilmaz eoyilmaz self-assigned this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eoyilmaz eoyilmaz

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@eoyilmaz