-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unavailable feed is not reported in metrics, root cause is unclear #452
Comments
In fact, there a two unrelated issues: the exception is not related to the unavailable feed, but caused by a missing form_factor in https://gbfs.nextbike.net/maps/gbfs/v2/nextbike_eh/en/vehicle_types.json: The above exception was not the first of it's kind in the logs and due to JVM optimizations (see this StackOverflow answer) lacked the stacktrace of the causing NPE. Scrolling up in the logs reveals the root cause: the update fails as the ingested feed apparently does not provide a formFactor for all of it's vehicleTypes:
|
Expected behavior
A feed that has been subscribed to successfully but turns unavailable (e.g. due to exceptions when parsing a result) should be reported in the metrics.
Observed behavior
For some of our feeds, we receive NPEs during update. Neither is the reason recognizable from the exception, nor is the system_id:
To debug this issue, this discussion of NPEs in ForkJoinPool might be helpful.
I suggest to let
GbfsSubscription.update
throw a custom Lamassu exception in case of error, providing a) the system Id and b) the causing exception including stacktrace. Additionally, the FeedUpdater might provide appropriate metric state for this subscription.Version of lamassu used (exact commit hash or JAR name)
373e17a
Steps to reproduce the problem
Can't yet reproduce locally.
The text was updated successfully, but these errors were encountered: