Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic discovery url handling #263

Open
testower opened this issue Sep 19, 2023 · 0 comments
Open

Dynamic discovery url handling #263

testower opened this issue Sep 19, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@testower
Copy link
Collaborator

I'm planning to remove the current "gbfs-internal" endpoint feature and replace it with dynamic url handling based on the Host header.

The reason we have this "gbfs-internal" endpoint is that we have a separate caching service between our instance of lamassu and our OTP instance. The hostname of this internal service is configured in lamassu so that the caching service can point to the gbfs-internal endpoint and receive discovery files with URLs rewritten to use that hostname.

I think we can instead bake this feature into the main endpoint by reading the Host header and rewriting urls based on that.

@testower testower added the enhancement New feature or request label Sep 20, 2023
@testower testower self-assigned this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant