Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setattr_original_value should be a property of the TraitType #1695

Open
mdickinson opened this issue Aug 9, 2022 · 0 comments
Open

setattr_original_value should be a property of the TraitType #1695

mdickinson opened this issue Aug 9, 2022 · 0 comments
Labels
component: core Issues related to the core library type: refactor

Comments

@mdickinson
Copy link
Member

mdickinson commented Aug 9, 2022 •
edited

[From #1645]

TraitType.clone needs to know the value of setattr_original_value for the associated ctrait, resulting in this awkwardness in the clone method (following merge of #1645)

setattr_original_value = new.as_ctrait().setattr_original_value

Instead, we should make setattr_original_value an attribute of the TraitType itself.
@mdickinson mdickinson added type: refactor component: core Issues related to the core library labels Aug 9, 2022
@mdickinson mdickinson mentioned this issue Aug 9, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: core Issues related to the core library type: refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdickinson