Always send an ABANDONED message to acknowledge cancellation #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Making this a draft; there's an aspect that I want to think about a bit more. |
To elaborate: with the model in this PR, and with For now, I'm closing this PR. We can revisit when #437 is looked at again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the refactor started in #392
In #392, a task that was cancelled prior to execution starting sent an ABANDONED message instead of a STARTED message; that way we weren't inventing a
Nonereturn value.In this PR, a task where cancellation is discovered during execution also sends an ABANDONED message, instead of inventing a return value of
None.Closes #445
Closes #437