Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the ABANDONED message type available to use in BaseTask #437

Open
mdickinson opened this issue Jul 19, 2021 · 0 comments
Open

Make the ABANDONED message type available to use in BaseTask #437

mdickinson opened this issue Jul 19, 2021 · 0 comments
Labels
type: refactor Cleanup or refactoring tasks that don't add functionality or fix bugs
Milestone

Comments

@mdickinson
Copy link
Member

#392 refactored what's now the BaseTask to add a new ABANDONED message type, used for cancellation. That fixed a situation where we were inventing a bogus return value of None when the task wasn't even being executed.

But individual tasks are still inventing a bogus return value of None in response to cancellation. We could fix up the BaseTask to make it easier to check for cancellation and send the ABANDONED message if cancellation occurred.

Examples of the bogus return value:

@mdickinson mdickinson added this to the Release 0.4.0 milestone Jul 26, 2021
@mdickinson mdickinson added the type: refactor Cleanup or refactoring tasks that don't add functionality or fix bugs label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor Cleanup or refactoring tasks that don't add functionality or fix bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant