Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace TimeoutTimer with CallbackTimer in GuiTestAssistant #251

Open
mdickinson opened this issue Nov 26, 2020 · 0 comments
Open

Replace TimeoutTimer with CallbackTimer in GuiTestAssistant #251

mdickinson opened this issue Nov 26, 2020 · 0 comments
Labels
type: refactor Cleanup or refactoring tasks that don't add functionality or fix bugs

Comments

@mdickinson
Copy link
Member

mdickinson commented Nov 26, 2020

In the wx version of the GuiTestAssistant we're writing our own TimeoutTimer class. We should be using the Pyface provided CallbackTimer instead, but it's currently causing segfaults (enthought/pyface#815). Once that's fixed upstream, we should replace the instantiation of TimeoutTimer with something like

timeout_timer = CallbackTimer(
    interval=timeout,
    repeat=1,
    callback=lambda: wx_app.exit(1),
)
@mdickinson mdickinson mentioned this issue Nov 26, 2020
2 tasks
@mdickinson mdickinson added the type: refactor Cleanup or refactoring tasks that don't add functionality or fix bugs label Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor Cleanup or refactoring tasks that don't add functionality or fix bugs
Projects
None yet
Development

No branches or pull requests

1 participant