Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support additional cred attributes #108

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

Support additional cred attributes #108

wants to merge 24 commits into from

Conversation

itziakos
Copy link
Member

@itziakos itziakos commented Apr 6, 2022 •
edited

fixes #105

  • Factor out a module for constants
  • Add support for Attributes and AttributeCount (ctypes and cffi).
  • Add basic tests for the Credential class
  • Add support for lastwritten in CREDENTIAL...

Note: Currently only a single credential_attribute is supported when writing credentials

@itziakos itziakos marked this pull request as draft April 6, 2022 08:38
@itziakos itziakos force-pushed the support-additional-cred-attributes branch from b393ae9 to 8174d04 Compare May 14, 2022 12:42
@itziakos itziakos force-pushed the support-additional-cred-attributes branch from 647c8b3 to ba548d2 Compare November 27, 2022 17:10
@itziakos itziakos force-pushed the support-additional-cred-attributes branch from ba548d2 to 2170d4c Compare April 26, 2023 14:16
@itziakos itziakos force-pushed the support-additional-cred-attributes branch from a3b79eb to 8d53a4c Compare March 23, 2024 12:03
@itziakos itziakos force-pushed the support-additional-cred-attributes branch from fab8d20 to 903d7e7 Compare April 24, 2024 11:42
itziakos and others added 24 commits May 4, 2024 10:33
@itziakos
Factor out constants for pywin32 submodule
d827aa9
@itziakos
Move constants to a top level module
2e0af23
@itziakos
Remove constrains to AttributeCount and Attribute
7cd498b 
This is a cleanup commit. The code is still not fully functional.
@itziakos
Add test module for the core authentication module
6ae5ddb
@itziakos
Fix flake8 errors
fe43484
@itziakos
Fix import
a62e87b
@itziakos
Fix import to constants
b28a612
@itziakos
Fix errors from rebase
16b730e
@itziakos
Another draft attempt to support CREDENTIAL_ATTRIBUTES with ctypes
e3b0e18
@itziakos
Add more credential related constants
b78d142
@itziakos
re-enable tests
817bee3
@itziakos
Fix flake8 errors
b221030
@itziakos
restrict writing one credential attribute for ctypes
56412d7
@itziakos
Test reading mulitple credential attributes
4c1fb2e
@itziakos
Add note about the current limitations of the implementation
3eb86a7
@itziakos
Fix flake8 errors
9b5870a
@itziakos
Support credential atrributes in cffi backend
143ac5e
@itziakos
Update tests for the authentication module
d1634ff
@itziakos
minor cleanup
d4a36c9
@itziakos
Fix linting errors
ce34dc0
@itziakos
Fix credential attribute convetion for ctypes
ce90333
@itziakos
Augment testing
11fc4f1 
Use parameterized to group tests
@itziakos
Update code to avoid memory access issues
d3edc92 
- Augment tests to detect issue
- Update cffi backend to fix memory issues
- Cleanup and remove unused global variables
@itziakos
fix flake8 errors
38b490c
@itziakos itziakos force-pushed the support-additional-cred-attributes branch from 638d5a6 to 38b490c Compare May 4, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

question re CREDENTIAL __DO_NOT_USE_ fields in _authentication.py
1 participant
@itziakos