Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Edge Examples Quay Repos #83

Open
EdwinWiseOne opened this issue Apr 24, 2024 · 3 comments
Open

Clean up Edge Examples Quay Repos #83

EdwinWiseOne opened this issue Apr 24, 2024 · 3 comments

Comments

@EdwinWiseOne
Copy link
Contributor

@dpinte @akhalighi

There are a bunch of old things in the edge examples space that need removing if they are not used (the question is -- are they used? And can we shift off of them if they are?)

  • edge-streamlit-demo was last updated a year ago, and the streamlist example is now in edge-streamlit-example repo. Is edge-streamlit-demo unique from the -example form?
  • *-core repos were used during example development going to the new Edge Proxy structure and these are no longer needed.
  • edge-native-flask-app-demo is the repository for the React example and it has a bunch of tags that we might be able to delete (keeping tags 1.1.0 and 1.3.0 only):
    • react (old naming?)
    • streamlit5, streamlit4, streamlit3, streamlit2, streamlit (now has its own repo)
    • plotly-example (now has its own repo)
    • panel-example (now has its own repo)
    • edge-minimal-example (now has its own repo)
    • testing
    • latest (we should use version numbers and not latest, for predictability)
    • dash
    • 1.1 (shouldn't this be 1.1.0? Which exists)
@dpinte
Copy link
Member

dpinte commented Apr 24, 2024

@EdwinWiseOne +1 to clean up as soon as we don't need those. I'll have a look asap.

@jychuah
Copy link
Contributor

jychuah commented Apr 29, 2024

Here is a list of images currently in use by applications in production edge.enthought.com:

Organization: default Application minimal-demo: quay.io/enthought/edge-example-minimal:1.0.0
Organization: default Application panel-demo: quay.io/enthought/edge-panel-example:1.1.0
Organization: default Application plotly-dash-demo: quay.io/enthought/edge-plotly-dash-example:1.1.0
Organization: default Application react-demo: quay.io/enthought/edge-native-app-flask-demo:react
Organization: default Application streamlit-demo: quay.io/enthought/edge-streamlit-example:1.1.0
Organization: demo Application demodashboard: quay.io/enthought/edge-dashboard-demo:latest
Organization: demo Application demonative: quay.io/enthought/edge-native-app-flask-demo:1.3.0
Organization: demo Application demostreamlit: quay.io/enthought/edge-streamlit-demo:latest
Organization: testorg Application testdashboard: quay.io/enthought/edge-dashboard-demo:latest
Organization: testorg Application testnative: quay.io/enthought/edge-native-app-flask-demo:latest
Organization: testorg Application testnative: quay.io/enthought/edge-native-app-flask-demo:1.1
Organization: testorg Application teststreamlit: quay.io/enthought/edge-streamlit-demo:latest

In removal of applications, we need to make sure that:

@carlosdtrejo
Copy link
Contributor

The dashboard app is located here: https://github.com/enthought/edge-examples/tree/97560c9aa25f2c3c4b68de036ce0678ad5e73bf1/dashboard-app-example.

We will keep using this image "edge-dashboard-demo" as part of our e2e testing but we should move it to another location than the edge-examples repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants