Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The multi-component menu should disappear after the group button is clicked #9903

Closed
AdRiley opened this issue May 9, 2024 · 3 comments · Fixed by #9924
Closed

The multi-component menu should disappear after the group button is clicked #9903

AdRiley opened this issue May 9, 2024 · 3 comments · Fixed by #9924
Assignees
@kazcw
Labels
--bug Type: bug -gui d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint
Milestone
Beta Release

Comments

@AdRiley
Copy link
Member

AdRiley commented May 9, 2024

The multi-component menu should disappear after the group button is clicked as once you have grouped there are no longer multiple components selected.

Actual:
image

Expected:
The multi-component menu should disappear
@AdRiley AdRiley added --bug Type: bug -gui labels May 9, 2024
@AdRiley AdRiley added this to the Beta Release milestone May 9, 2024
@farmaazon
Copy link
Contributor

Interesting. Looks really like we still have those nodes selected, somehow.

@farmaazon farmaazon added d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints labels May 9, 2024
@farmaazon
Copy link
Contributor

There should another list of "actually selected" nodes (the current selection, with non-existing nodes filtered out) - a computed value.
There are some places in code where we already do that - unify them.

@farmaazon farmaazon added p-high Should be completed in the next sprint and removed p-medium Should be completed in the next few sprints labels May 9, 2024
@kazcw kazcw self-assigned this May 10, 2024
@kazcw kazcw mentioned this issue May 10, 2024
Merged
4 tasks
@enso-bot
Copy link

enso-bot bot commented May 10, 2024

Keziah Wesley reports a new STANDUP for today (2024-05-10):

Progress: Fixed issues with selection containing components that don't exist. It should be finished by 2024-05-10.

Next Day: Next day I will be working on the #9907 task. Work on doc editor link handling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazcw kazcw

Labels
--bug Type: bug -gui d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint
Projects
Issues Board
Status: 🟢 Accepted
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

Track live selection enso-org/enso
3 participants
@kazcw @AdRiley @farmaazon