Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd + ? Keybind Does Not Show Enso Version #9433

Closed
1 of 2 tasks
indiv0 opened this issue Mar 14, 2024 · 4 comments · Fixed by #9833
Closed
1 of 2 tasks

cmd + ? Keybind Does Not Show Enso Version #9433

indiv0 opened this issue Mar 14, 2024 · 4 comments · Fixed by #9833
Assignees
@somebody1234
Labels
--bug Type: bug -gui d-easy Difficulty: little prior knowledge required g-dashboard p-high Should be completed in the next sprint
Milestone
Beta Release

Comments

@indiv0
Copy link
Contributor

indiv0 commented Mar 14, 2024 •
edited

Discord username

npekin

What type of issue is this?

Permanent – Occurring repeatably

Is this issue blocking you from using Enso?

  • Yes, I can't use Enso because of this issue.

Is this a regression?

  • Yes, previous version of Enso did not have this issue.

What issue are you facing?

I tried to report a bug, and the bug report form asked me to provide the Enso version by using the cmd + ? keybind.

image

Using that keybind does not show the Enso version, instead it opens some kind of help search bar.

Expected behaviour

Enso version should be displayed when the cmd + ? keybind is pressed

How we can reproduce it?

  1. Open standalone Enso GUI
  2. Press cmd + ? (on macOS)
  3. Observe the lack of version displayed

Screenshots or screencasts

image

Logs

No response

Enso Version

It's literally unknowable 😱😱😱 (just kidding it's a2507abcdb2c375d094dc4d4ce4e7c731cba69f1)

Browser or standalone distribution

Standalone distribution (cloud project)

Browser Version or standalone distribution

standalone

Operating System

MacOS

Operating System Version

Sonoma 14.1.1 (23B81)

Hardware you are using

M2 Macbook Air 24GB
@indiv0 indiv0 added d-easy Difficulty: little prior knowledge required --bug Type: bug triage -gui labels Mar 14, 2024
@farmaazon farmaazon added this to the Beta Release milestone Mar 18, 2024
@AdRiley
Copy link
Member

AdRiley commented Mar 21, 2024

We should also add a menu option under the ... menu to get this

@farmaazon
Copy link
Contributor

farmaazon commented Mar 21, 2024 •
edited

Refinement note:

  1. Use the ref/branch/tag name on which it was built, from environment variable. Vite should put the value to some global.
  2. Shortcut should work both in GUI and dashboard
  3. Important: the version name should be copyable, or better: with "copy" button.
  4. Also, we could put UserAgent there.
  5. You should not have to press shift, so effectively it is cmd+/
  6. Rather the dashboard task, as we want this shortcut to work globally.

@somebody1234 somebody1234 self-assigned this Apr 29, 2024
@somebody1234 somebody1234 added the p-high Should be completed in the next sprint label Apr 29, 2024
@somebody1234 somebody1234 mentioned this issue May 2, 2024
Merged
4 tasks
@somebody1234
Copy link
Collaborator

note re:

You should not have to press shift, so effectively it is cmd+/

in fact we can't use ctrl+shift+?, because (as mentioned in the original post) it is a dedicated shortcut on macos to bring up the search tool to search through the application menus.

@enso-bot
Copy link

enso-bot bot commented May 2, 2024

E-Hern Lee reports a new STANDUP for today (2024-05-02):

Progress: - finish implementation

  • address CR

other issues -

  • (wip) fix issues on local backend It should be finished by 2024-05-10.

@mergify mergify bot closed this as completed in #9833 May 14, 2024
@mergify mergify bot closed this as completed in f041176 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@somebody1234 somebody1234

Labels
--bug Type: bug -gui d-easy Difficulty: little prior knowledge required g-dashboard p-high Should be completed in the next sprint
Projects
Issues Board
Status: 🟢 Accepted
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

Add "About app" modal enso-org/enso
4 participants
@indiv0 @AdRiley @farmaazon @somebody1234