Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make grouped components take the icon from the group's comment #9831

Closed
AdRiley opened this issue May 1, 2024 · 2 comments · Fixed by #10020
Closed

Make grouped components take the icon from the group's comment #9831

AdRiley opened this issue May 1, 2024 · 2 comments · Fixed by #10020
Assignees
@kazcw
Labels
-gui p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Milestone
Beta Release

Comments

@AdRiley
Copy link
Member

AdRiley commented May 1, 2024

  • Make grouped components take the icon from the group's comment
  • Default new groups to ## ICON group
@AdRiley AdRiley added x-new-feature Type: new feature request -gui labels May 1, 2024
@AdRiley AdRiley added this to the Beta Release milestone May 1, 2024
@farmaazon
Copy link
Contributor

The first point should already work, but sometimes we miss the local entries in suggestion db (or they are not updated). Check the not working scenarios and file a bug to the engine as part of this task.

@farmaazon farmaazon added p-high Should be completed in the next sprint p-medium Should be completed in the next few sprints and removed p-high Should be completed in the next sprint labels May 9, 2024
@kazcw kazcw self-assigned this May 21, 2024
@kazcw kazcw mentioned this issue May 21, 2024
Merged
4 tasks
This was referenced May 21, 2024
Closed
Open
mergify bot pushed a commit that referenced this issue May 22, 2024
@kazcw
Use group icon for components created by grouping. (#10020)
fcfc081 
Use `group` icon for components created by grouping.

https://github.com/enso-org/enso/assets/1047859/50a0dbb6-d36e-4fcb-9f39-b6493b8cca86

See: #9831.

# Important Notes
- This PR always sets the icon, but it is not always shown due to missing updates from the backend; this issue is currently being investigated.
@kazcw kazcw linked a pull request May 24, 2024 that will close this issue
Use group icon for components created by grouping. #10020
Merged
4 tasks
@kazcw
Copy link
Contributor

kazcw commented May 24, 2024

Make grouped components take the icon from the group's comment

Seems to have been fixed with #9962.

Default new groups to ## ICON group

Implemented in #10020

@kazcw kazcw closed this as completed May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazcw kazcw

Labels
-gui p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Projects
Issues Board
Status: 🟢 Accepted
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

Use group icon for components created by grouping. enso-org/enso
3 participants
@kazcw @AdRiley @farmaazon