Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outputting at specified steps? #108

Open
RonRahaman opened this issue Aug 18, 2020 · 2 comments
Open

Outputting at specified steps? #108

RonRahaman opened this issue Aug 18, 2020 · 2 comments

Comments

@RonRahaman
Copy link
Collaborator

RonRahaman commented Aug 18, 2020

Currently, ENRICO calls Driver::write_step at every Picard iteration. I would be interested in specifying only certain Picard iterations and/or timestep intervals for calling write_step. For example, I'd be especially interested in calling write_step at only the final Picard iteration of each timestep.

For OpenmcDriver, this seems pretty easy to implement, since OpenmcDriver::write_step simply calls the openmc_statepoint_write API function from OpenMC. In that case, we could conditionally call write_step in CoupledDriver::execute

For NekDriver, it will be more difficult. To write the step, we don't directly call an API function from Nek5000. We simply rely on Nek to write the statepoint during the nek_solve API function, which is called in NekDriver::solve_step. Hence, conditionally calling write_step won't change the behavior. I'm looking at ways to workaround this, and I think I have some leads.

For SHIFT, I can't see what would need to happen.

@paulromano
Copy link
Member

One could start with at least having the user input and allowing this to happen in principle, even if NekDriver doesn't listen to it.

@sphamil
Copy link
Contributor

sphamil commented Aug 20, 2020

The Shift tally output is currently wrapped up in the solve. It will take a little bit of reorganization on the Shift side to separate those into distinct methods. Like @paulromano said, we could expose this as an input option and note that it isn't yet supported by all solver selections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants