Empty string in message.event field causes a runtime error.

[extremegf]

From RFC8895

The protocol defines three field names: event, id, and data. If a message has more than one "data" line, the value of the data field is the concatenation of the values on those lines. There can be only one "event" and "id" line per message. The "data" field is required; the others are optional.

The check below however fails when message.event === ""

graphql-sse/src/parser.ts

Line 88 in b4019e4

if (!message.event) throw new Error('Missing message event');

[enisdenjo]

The event field is required in the GraphQL over SSE spec because it serves the purpose of describing the type of the message being sent.

[extremegf]

That would suggest that Graphql Helix is out of spec, by not sending event: line. Shoud we open an issue at their side?

Relevant code:
https://github.com/contra/graphql-helix/blob/1bbc7146e953556498180c53aa1638dd25072d43/packages/core/lib/send-result/node-http.ts#L91

[enisdenjo]

GraphQL Helix is out of spec because it doesn't aim to implement it at all.

Nevertheless, I recommend using the well-maintained GraphQL Yoga instead. It also has a graphql-sse plugin that can get you going in no time.

[extremegf]

Note that I did install the plugin. It doesn't seem to be necessary (or is in stalled by default) as it works the same without it.

[enisdenjo]

@extremegf are you connecting to the stream endpoint /graphql/stream?

[extremegf]

No. So there's a spearate stream endpoint? I'll look it up.

[enisdenjo]

Yes, its stated in the graphql-sse plugin documentation. You can of course configure the endpoint, but the default is /graphql/stream.

[extremegf]

Thank you for the help! I really appreciate it!