Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of "uninhabited" attribute from planets is not handled correctly #10051

Open
1 task done
warp-core opened this issue May 10, 2024 · 0 comments
Open
1 task done
Labels
bug Something in the game is not behaving as intended mechanics Things dealing with the mechanics & code of how the game works
Milestone

Comments

@warp-core
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Thanks to @MidnightPlugins for reporting this on Discord.

https://discord.com/channels/251118043411775489/536900466655887360/1238291650925559898

When the "uninhabited" attribute is addd to Kraken Station, it is given the "default uninhabited port" that is, it has a spaceport button, but no other services (trade, job board, bank, hiring).
This is added by:

// For reverse compatibility, if this planet has a spaceport but it was not custom loaded,
// and the planet has the "uninhabited" attribute, replace the spaceport with a special-case
// uninhabited spaceport.
if(attributes.count("uninhabited") && HasNamedPort() && !port.CustomLoaded())
port.LoadUninhabitedSpaceport();

When the "uninhabited" attribute is removed, there is nothing that restores the full "port" services that it should have.

Steps to Reproduce

Load the attached save file.
See that Kraken Station doesn't have all the services it should.

Expected Behavior

The planet probably shouldn't keep the default assigned uninhabited spaceport after the "uninhabited" attribute is removed.

Screenshots

No response

Link to save file

Save file provided by @MidnightPlugins.
test_kraken_attributes.txt

Operating System

Windows 10 Pro 21H2

Game Source

Built from source

Game Version

1e19d35

Additional Information

No response

@warp-core warp-core added bug Something in the game is not behaving as intended unconfirmed More information is needed to be sure this report is true labels May 10, 2024
@Amazinite Amazinite removed the unconfirmed More information is needed to be sure this report is true label May 11, 2024
@Amazinite Amazinite added this to the 0.10.7 milestone May 11, 2024
@TomGoodIdea TomGoodIdea added the mechanics Things dealing with the mechanics & code of how the game works label May 13, 2024
@Amazinite Amazinite modified the milestones: 0.10.7, 0.10.8 May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something in the game is not behaving as intended mechanics Things dealing with the mechanics & code of how the game works
Projects
None yet
Development

No branches or pull requests

3 participants