Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keywords / Filters to select groups of ships in datafilecontent #10041

Open
petervdmeer opened this issue May 4, 2024 · 2 comments
Open

Keywords / Filters to select groups of ships in datafilecontent #10041

petervdmeer opened this issue May 4, 2024 · 2 comments
Labels
enhancement A suggestion for new content or functionality that requires code changes mechanics Things dealing with the mechanics & code of how the game works

Comments

@petervdmeer
Copy link
Member

petervdmeer commented May 4, 2024

Problem Description

Some features like formation-flying, tagging of ships, locking/unlocking ship-fucntions and teleporting would benefit from (or even require) having the ability to select (groups of) operational ships, for example for formation-positions (only certain ships at certain formation positions) or for selecting which ships to tag or which ships to teleport along with the player.

We can discuss such ShipFilters in any of those feature-requests, but it seems valid to also have a separate ticket to discuss this specifically.

Related Issue Links

Desired Solution

The LocationFilter class and the wiki on filtering (https://github.com/endless-sky/endless-sky/wiki/CreatingMissions#filters) seems to be a good starting location. What I would like to see is a specific type of filter that allows me to select active ships both from the player as well as non-player (for example escort) ships.

Some selection-criteria which I already came up with:

  • flagship (explicit, special case)
  • ships selected by a location filter
    • ships in the players system
    • ships in the players planet
    • ships in specific systems
    • ships in systems close to another system
  • ships selected by attributes (having them or not having them, having an attribute not set)
  • ship (static) properties
    • Cargo space
    • Nr of bunks
    • Type
    • Category
    • Certain outfits installed (or not installed)
  • active (runtime) ship properties
    • Amount of cargo
    • Nr of Passengers
    • ships being carried
    • Nr of ships carried
    • Ships being disabled
    • Ships being parked
  • Owner
    • Both player-owned as well as certain government owned
  • Selected by player (not supported by the examples, but might be valuable for other usecases) => unlikely to be used often in story-content.

The feature should be available to be embedded in other features using some keyword. The keyword itself can be specific to the feature on top.

Alternative Approaches

Extending locationfilters or creating a new type of filter seem to be 2 different directions in which this can be implemented. I feel that a new type of filter (that can include location filters to select ships on a location) would work best.

Additional Context

No response

@petervdmeer petervdmeer added enhancement A suggestion for new content or functionality that requires code changes mechanics Things dealing with the mechanics & code of how the game works labels May 4, 2024
@xX-Dillinger-Xx
Copy link

Selected by player

I like the idea of being able to select certain ships, adding them to specific groups, and be able to issue commands to those groups. It adds some much needed fleet support. I know fleet play isn't the intended experience but it is defiantly a part of the game, particularly for 1st time players.
Case uses:

  • getting freighters and other support groups to wait at a safe distance until my combat group has cleared the system.
  • setting traps by placing group A out away from system center and then baiting enemy to chase me into the trap.

@petervdmeer
Copy link
Member Author

petervdmeer commented May 6, 2024

Selected by player

I like the idea of being able to select certain ships, adding them to specific groups, and be able to issue commands to those groups. It adds some much needed fleet support.

This feature already exists (using numeric keys, with and without control) and is not what this feature-request is about.

I know fleet play isn't the intended experience but it is defiantly a part of the game, particularly for 1st time players. Case uses:

  • getting freighters and other support groups to wait at a safe distance until my combat group has cleared the system.
  • setting traps by placing group A out away from system center and then baiting enemy to chase me into the trap.

Yes, that is what I used group selection for as well, but that is not what this feature-request is for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A suggestion for new content or functionality that requires code changes mechanics Things dealing with the mechanics & code of how the game works
Projects
None yet
Development

No branches or pull requests

2 participants