Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Reduced image quality in Water4 caused by #9459 #10004

Open
1 task done
Zitchas opened this issue Apr 20, 2024 · 3 comments
Open
1 task done

[Bug] Reduced image quality in Water4 caused by #9459 #10004

Zitchas opened this issue Apr 20, 2024 · 3 comments
Labels
artwork Everything related to images, sprites, and graphics bug Something in the game is not behaving as intended

Comments

@Zitchas
Copy link
Member

Zitchas commented Apr 20, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

PR #9459, in addition to updating some copyright issues, also replaced several pictures. Two of the pictures are, as described in the PR, virtually un-distinguishable. Unfortunately, Water4 is decidedly brighter and more pink, and I think is just overall worse quality.

Steps to Reproduce

  1. Go to PR Fix copyright for unsplash images #9459
  2. Click on the changes to see the comparison
  3. See error

Expected Behavior

If we're replacing a picture, I would expect the picture to be equal to or superior in quality; not a downgrade.

If we need to replace that picture to adhere to copyright, then I would suggest that we do our own color balancing work on the image to bring it back inline with the old version.

Screenshots

No response

Link to save file

No response

Operating System

Windows 10 Pro

Game Source

Built from source

Game Version

commit 46a392f

Additional Information

No response

@Zitchas Zitchas added bug Something in the game is not behaving as intended unconfirmed More information is needed to be sure this report is true labels Apr 20, 2024
@ziproot
Copy link
Contributor

ziproot commented Apr 21, 2024

Here is water4 with saturation reduced by 50% and hue shifted to the left 10% using imagemagick:
water4

As the pixabay version is public domain, editing the image would not be a problem.

EDIT: In case people want to use this image in particular, my edit is CC0.

@bene-dictator bene-dictator added artwork Everything related to images, sprites, and graphics and removed unconfirmed More information is needed to be sure this report is true labels Apr 21, 2024
@OcelotWalrus
Copy link
Contributor

OcelotWalrus commented Apr 23, 2024

Indeed, the original image has a better quality (in my opinion)
image

The new image seems to be way too much saturated. Maybe the change should be reverted? Or reworked on?

@mOctave
Copy link
Contributor

mOctave commented Apr 24, 2024

I think Ziproot's edit is a passable replacement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artwork Everything related to images, sprites, and graphics bug Something in the game is not behaving as intended
Projects
None yet
Development

No branches or pull requests

5 participants