Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Standardise the leave/done/depart text and hotkeys #10000

Open
brendanjones opened this issue Apr 18, 2024 · 10 comments
Open

Idea: Standardise the leave/done/depart text and hotkeys #10000

brendanjones opened this issue Apr 18, 2024 · 10 comments
Labels
UI Everything related to the User Interface & Design (both artwork and code)

Comments

@brendanjones
Copy link
Contributor

brendanjones commented Apr 18, 2024

Problem Description

As a seasoned player you'd think I'd be very used to these by now, but I still find myself hitting the wrong button to leave some places.

The various buttons we have to navigate away from places:

Done: Player Info, Map, Jobs (which is Map)
Leave: Shipyard, Outfitter
Depart: Leave planet
None: Messages (have to re-press the Messages hotkey, press escape, or click off the Messages panel), Spaceport (kinda related #3389), Bank, Trading, Hire Crew.

Pressing D will let you leave the Shipyard and Outfitter, but pressing L will not let you leave Player Info (it'll instead open the Logbook) or Map.

Related Issue Links

Can't find any.

Desired Solution

Is the idea that you don't accidentally leave the planet? Because then I'd say:

  1. change Leave to Done in the Shipyard and Outfitter, and
  2. change Depart to Leave Launch.
  3. Stop L hotkey leaving Outfitters and Shipyard.
  4. Messages should have a Done button added. (could do at same time as Add an empty state to the Messages panel #9999 )

That standardises all dismissal actions to Done (with hotkey D) except for leaving the planet.

Alternative Approaches

Open to discussion.

Additional Context

No response

@brendanjones
Copy link
Contributor Author

Hey Issue #10000 whaddupppppp that's a cool milestone.

@xX-Dillinger-Xx
Copy link

xX-Dillinger-Xx commented Apr 18, 2024

If I follow your idea correctly, D would exit everywhere except the planet and L would leave\launch. Is that correct?
If it is, that all makes sense to me, but I would like to suggest one small edit.

and change Depart to Leave.

Change Depart to Launch

@brendanjones
Copy link
Contributor Author

If I follow your idea correctly, D would exit everywhere except the planet and L would leave\launch. Is that correct?

Correct.

Change Depart to Launch

That is an excellent suggestion, will change the issue description.

@xX-Dillinger-Xx
Copy link

I really like this idea.

@Ferociousfeind
Copy link
Contributor

Makes sense to me, especially if L is also Land, so L toggles whether or not you're on a planet

Also happy 10k, we got there before the SCP wiki did

@TomGoodIdea TomGoodIdea added the UI Everything related to the User Interface & Design (both artwork and code) label Apr 19, 2024
@brendanjones
Copy link
Contributor Author

brendanjones commented Apr 19, 2024

especially if L is also Land, so L toggles whether or not you're on a planet

Yup, exactly. That was why I suggested Leave/Launch with an L, while the others get changed to D.

@ziproot
Copy link
Contributor

ziproot commented Apr 21, 2024

I think endless sky follows IBM CUA, so pressing esc lets you escape shipyard, outfitter, player info panel, message log, etc. The only time this won’t work is for departing a planet, which is the d key, as pressing esc takes you back to the main menu.

@TomGoodIdea
Copy link
Member

Worth noting that L is currently used on the planet interface to return to the planet's description (same effect as clicking the landscape image).

@Ferociousfeind
Copy link
Contributor

We should change it from "L" for Landscape to "D" for Describe :)

@brendanjones
Copy link
Contributor Author

(same effect as clicking the landscape image).

Had no idea that was a thing! Still not matter how long I play there are still things to learn :)

And yeah, if all the other non Launch hotkeys are D then it seems logical to me to also switch that one to D.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Everything related to the User Interface & Design (both artwork and code)
Projects
None yet
Development

No branches or pull requests

5 participants