Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collecting Assertions #15

Open
1 task
emjun opened this issue Jan 11, 2021 · 0 comments
Open
1 task

Collecting Assertions #15

emjun opened this issue Jan 11, 2021 · 0 comments

Comments

@emjun
Copy link
Owner

emjun commented Jan 11, 2021

Right now, collecting and formatting assertions from properties of variables and effects sets is blended together into one step (see Tisane.collect_assertions and helper methods)

Seems to me that the right/better design would be:
collect assertions -> dict [in Tisane class where going to be controlling modeling?]
format assertions -> can pick ASP vs. SMT (hypothetically) although we are focusing on ASP [helper method]
query with assertions -> knowledge base [KnowledgeBase is just a wrapper around the ASP solving process]

Pro:

  • makes code more modular and therefore more extensible
    Con:
  • more work to do 😛
  • update, add new tests

Related Issues: Issue #9, #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant