Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird error for Effects #10

Open
emjun opened this issue Jan 6, 2021 · 0 comments
Open

Weird error for Effects #10

emjun opened this issue Jan 6, 2021 · 0 comments
Labels
bug Something isn't working easy

Comments

@emjun
Copy link
Owner

emjun commented Jan 6, 2021

In EffectSet class, it's possible to have self.interaction = InteractionEffect(effect=None) . This should be self.interaction = None.

I don't think having effect = None makes sense.

Changing this requires updating the has_<main/interaction/mixed>_effects() functions.

@emjun emjun added bug Something isn't working easy labels Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working easy
Projects
None yet
Development

No branches or pull requests

1 participant