Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onOpenChange getting called twice when user clicks outside of the drawer #290

Closed
phxgg opened this issue Mar 7, 2024 · 2 comments · May be fixed by #291
Closed

onOpenChange getting called twice when user clicks outside of the drawer #290

phxgg opened this issue Mar 7, 2024 · 2 comments · May be fixed by #291

Comments

@phxgg
Copy link

phxgg commented Mar 7, 2024 •
edited

For some reason, onOpenChange gets called twice when a user clicks outside the drawer.

This does not happen when a user manually drags the drawer to the bottom.

Observe console logs on this sandbox: https://codesandbox.io/p/devbox/drawer-with-scale-forked-t29rgr
@phxgg phxgg mentioned this issue Mar 7, 2024
Open
@LakshayGMZ
Copy link

encountering same issue, please fix maintainers!!

@emilkowalski
Copy link
Owner

Fixed in #297

@phxgg phxgg mentioned this issue May 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: onOpenChange getting called twice when user clicks outside of the drawer phxgg/vaul
3 participants
@emilkowalski @phxgg @LakshayGMZ