-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a User-Agent header to HTTP image loader #4491
Comments
Sounds good - PRs welcome! |
Are we going for a hard coded user agent or a configurable one? I could take a crack at it |
I've been looking through the code a bit and found out that egui-extras uses ehttp for the http ImageLoader which has hardcoded headers of just Do you want to simply pass the headers into ehttp::Request::get function, a builder pattern? ( |
So a few hours of debugging and I found out that the URL I use to fetch images has unescaped qoutes ( |
A hard-coded |
Is your feature request related to a problem? Please describe.
I'm trying to make an egui program that shows images loaded from an CDN, but it requires that the request has a user agent as a header.
Describe the solution you'd like
Either hardcore the user agent header into the code handling HTTP image loading or add a way to allow passing in a custom user agent
Describe alternatives you've considered
Loading the image using reqwest as bytes and use ImageSource::Bytes in Image
Additional context
The text was updated successfully, but these errors were encountered: