Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make axon Threading heuristics MPI aware #197

Open
siboehm opened this issue Apr 20, 2023 · 2 comments
Open

Make axon Threading heuristics MPI aware #197

siboehm opened this issue Apr 20, 2023 · 2 comments

Comments

@siboehm
Copy link
Member

siboehm commented Apr 20, 2023

It's better to do the threading settings in Axon, instead of setting GOMAXPROCS on infra. Allows us to change it more easily, and adapt to different model sizes.

This will get slightly more complex for cross machine (we'll have to do OMPI_COMM_TYPE_HOST comm splitting).

@siboehm
Copy link
Member Author

siboehm commented Apr 21, 2023

@rcoreilly @etuleu let's discuss here instead.

I'd prefer having the code have more knowledge about it's environment, that way it's much easier to update the heuristics and we don't need to touch infra code. We want to be able to do things like overallocate Goroutines, so adjusting down GOMAXPROCS may not even always be a bad idea.

Once emer/empi#11 is implemented, the code would also become aware of SLURM environments and LVIS would continue working as is.

@rcoreilly
Copy link
Member

I think it would be much cleaner and simpler to have one clear way of parameterizing and understanding what axon does (n mpi procs x t threads per proc), and let the infra send in the appropriate params explicitly, rather than having axon try to figure things out on its own. If we need an alternative to GOMAXPROCS then we can add that as a startup arg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants