Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate PageReader's constructor #1323

Open
dmikurube opened this issue Sep 14, 2020 · 0 comments
Open

Deprecate PageReader's constructor #1323

dmikurube opened this issue Sep 14, 2020 · 0 comments

Comments

@dmikurube
Copy link
Member

PageReader is now considered as a part of Embulk API. Although calling its constructor has been the only way to construct PageReader from plugins, PageReader should no longer provide its own constructor for plugins in embulk-api. Instead, Exec is going to have Exec.getPageReader.

  • v0.10: PageReader's constructor is marked as @Deprecated, and Exec.getPageReader is added. But Embulk v0.9-compatible plugins still have to call the constructor because Embulk v0.9 has only the constructor, no Exec.getPageReader.
  • v0.11: PageReader's constructor will still be kept, but plugins should start using Exec.getPageReader instead.
  • v1.0: PageReader's constructor would be removed at some early point of v1.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant