Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting ember-source dependency conflict with ember-source 5.3 #854

Open
hess8 opened this issue Nov 16, 2023 · 10 comments
Open

Getting ember-source dependency conflict with ember-source 5.3 #854

hess8 opened this issue Nov 16, 2023 · 10 comments

Comments

@hess8
Copy link

hess8 commented Nov 16, 2023

Trying to build with ember-engines with packages that use the latest versions of ember-source (v5) fails:

npm ERR! Could not resolve dependency:

npm ERR! peer ember-source@"^3.24.1 || 4" from ember-engines@0.9.0

npm ERR! node_modules/ember-engines

npm ERR!   dev ember-engines@"0.9.0" from the root project

I don't see the ember-source@"^3.24.1 || 4" dependency in ember-engines package.json.

@hess8
Copy link
Author

hess8 commented Nov 16, 2023

OK I see you made the dependency change 3 months ago. I must be using an outdated package.

@hess8 hess8 closed this as completed Nov 16, 2023
@hess8
Copy link
Author

hess8 commented Nov 16, 2023

I'm requiring 0.9.0, which is your repo version. Should the change in dependencies require 0.9.1?

I had to clone your repo and require a local npm install to get this to work, instead of requiring 0.9.0

@hess8 hess8 reopened this Nov 16, 2023
@aklkv
Copy link

aklkv commented Nov 17, 2023

@SergeAstapov could we have the latest changes released please, I getting the same message 🙏🏻

@SergeAstapov
Copy link
Contributor

@aklkv I'd love to help but don't have npm access, so need someone with enough permissions like @runspired or @rwjblue

@jkubaile
Copy link

Would be great to get the new version up, we are also struggling with the conflict 👍

@arisangar12
Copy link

Any update on this team? We were also facing this issue.
Kindly do the needful.
@runspired @rwjblue @SergeAstapov

@void-mAlex
Copy link
Collaborator

Any update on this team? We were also facing this issue. Kindly do the needful. @runspired @rwjblue @SergeAstapov

this is already fixed and merged, just waiting on a release which we're working on getting it asap
there is also #855 that looks to make 5.x ember source story much better

@void-mAlex
Copy link
Collaborator

fixed by #849

@arisangar12
Copy link

this is already fixed and merged, just waiting on a release which we're working on getting it asap there is also #855 that looks to make 5.x ember source story much better

Thank you for the information, @void-mAlex. Do you have any estimated time frame or date for the release?This would help me coordinate our plans accordingly.

@void-mAlex
Copy link
Collaborator

the are one or two small blockers to clear still, but roughly things should start rolling in the next two to three weeks
sooner if things go well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants