Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8.22 breaks compatability with Ember > 3.24 #843

Open
abhishek97 opened this issue Apr 17, 2023 · 2 comments
Open

0.8.22 breaks compatability with Ember > 3.24 #843

abhishek97 opened this issue Apr 17, 2023 · 2 comments
Labels

Comments

@abhishek97
Copy link

abhishek97 commented Apr 17, 2023

I see you'd need to add @ember/legacy-built-in-components for it work. As someone who wasted considerable time trying to find this information in the release notes, it would be great if we can add it there.

EDIT: It currently breaks even with it. Because we are trying to import @ember/routing which doesn't work and will break at line 1 here: https://github.com/BobrImperator/ember-engines/blob/4c3b2aec998be7fd1d61b55657d4714b59375f31/packages/ember-engines/addon/components/link-to-external.js#L1 and will never get the chance to import from @ember/legacy-built-in-components

@abhishek97
Copy link
Author

All in all, this feels like too big a change to be minor version bump.

@gvdp
Copy link

gvdp commented May 30, 2023

Experiencing the same issue with an upgrade to Ember v4, although for me adding @ember/legacy-built-in-components seemed to fix the error.
Also reading this comment I think the implementation of extending the LinkComponent class here is not possible because by design these classes are no longer extendable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants