Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class extends value [object Object] is not a constructor or null #813

Open
roncodes opened this issue Aug 25, 2022 · 3 comments
Open

Class extends value [object Object] is not a constructor or null #813

roncodes opened this issue Aug 25, 2022 · 3 comments

Comments

@roncodes
Copy link

Just had issues adding ember-engines@0.8.23 to a new ember app (4.6.0), on start throws this error Uncaught TypeError: Class extends value [object Object] is not a constructor or null

This was being thrown from the LinkToExternal component.

I realized that LinkComponent was removed from @ember/routing package starting at ember v4, and that the package @ember/legacy-built-in-components is required for ember-engines to work.

After adding @ember/legacy-built-in-components my new ember app loaded.

This isn't stated anywhere in the ember-engine docs, shouldn't this be noted in the installation section or somewhere in the docs?

Note: I installed ember-engines using yarn yarn add ember-engines and not ember install ember-engines ~ unsure if this matters?

@SergeAstapov
Copy link
Contributor

@roncodes thanks for logging the issue! This is indeed the miss in the documentation.

@roncodes btw, were you using https://ember-engines.com/docs/installation during your endeavor? I think that's the page where such info should be provided.

@roncodes
Copy link
Author

@SergeAstapov Yes I was using the docs installation page. I can create if a PR if it's needed or should indeed be included in the installation instruction for v4+ users.

@Yelinz
Copy link

Yelinz commented Oct 27, 2022

Same issue as #795

velrest added a commit to velrest/ember-emeis that referenced this issue Jan 26, 2023
velrest added a commit to velrest/ember-emeis that referenced this issue Jan 26, 2023
velrest added a commit to velrest/ember-emeis that referenced this issue Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants