Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app.import() content can end up in app's vendor instead of engine's #755

Open
aghassemi opened this issue Mar 9, 2021 · 1 comment
Open

Comments

@aghassemi
Copy link

aghassemi commented Mar 9, 2021

If a transitive dependency of a lazy-engine uses app.import() to load a package, it will end up in app's vendor.js instead of engine-vendor.js.

For example assume ember-d3 uses app.import to load d3.js, if my-lazy-engine depends on ember-d3, everything is fine and d3.js ends up in engine-vendor.js. But if my-lazy-engine depends on another-addon which depends on ember-d3, d3.js ends up in app's vendor and is not lazy-loaded anymore.

This might be because the the _findHost used in the case of transitive dep is not overwritten by ember-engines like the way direct dependency is.

@villander
Copy link
Member

@aghassemi could you please provide a minimal reproduction in a public repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants