You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When an lazy-engine is mounted to the root of the host app, the loading suvbstate will not be entered while the assets for the engine are being downloaded.
The loading state is entered in these cases:
After the assets are downloaded and the engine's application route is loading
If the engine is mounted to a subroute on the host application.
Two acceptance tests were added. One demonstrates that the intended functionality works when the engine is mounted to a child route, while the other demonstrates that this functionality doesn't work when mounted to the root.
Due to caching the downloaded assets in the test suite. The tests will inconsistently fail unless they are run separately.
The yarn run test-both command can be run to execute both tests in sequence, ensuring consistent test results.
I would be happy to take a stab at fixing this issue if I could be pointed in the right direction.
Thanks!
The text was updated successfully, but these errors were encountered:
Hey all馃憢
When an lazy-engine is mounted to the root of the host app, the loading suvbstate will not be entered while the assets for the engine are being downloaded.
The loading state is entered in these cases:
The docs for lazy engines indicates that this functionality should be present. https://ember-engines.com/docs/lazy-loading#loading-error-substates.
I have recreated this issue in this repo: https://github.com/camerondubas/ember-engine-loading-state
Two acceptance tests were added. One demonstrates that the intended functionality works when the engine is mounted to a child route, while the other demonstrates that this functionality doesn't work when mounted to the root.
Due to caching the downloaded assets in the test suite. The tests will inconsistently fail unless they are run separately.
The
yarn run test-both
command can be run to execute both tests in sequence, ensuring consistent test results.I would be happy to take a stab at fixing this issue if I could be pointed in the right direction.
Thanks!
The text was updated successfully, but these errors were encountered: