-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ember-typescript-cli v2 #437
Comments
One thing I have noticed is that a number of our ember add-on dependencies using Could this be a factor in my issue? |
Seeing the same, after upgrading This fails the build with that
While this works:
|
@simonihmig That was very helpful A quick hack to
->
Unfortunately, I'm now getting runtime issues which I'm looking into now. |
I would bet that usage of |
It looks like there's an issue for this in the Babel repo, but it hasn't gotten any love yet babel/babel#10059 |
Note: babel/babel#10059 was fixed with babel/babel#10578 (support string literal properties) |
I am having difficulty getting
ember-decorators
to work withember-cli-typescript v2
.Originally, I was running
ember-decorators@5.1.4
andember-cli-typescript@1.5.0
using experimentalDecorators and all was working.I made sure to update
ember-cli-babel
to7.7.3
and@babel/core
, etc to7.4.3
, and then installedember-cli-typescript@2.0.1
. At which point I not been able to get decorators working again.Initially I got this compile error
If I remove all the decorators from a given file then this error disappears for that file.
I then tried install
@ember-decorators/babel-transforms
and the project compiles but when I run my tests I get errors like thisI've tried disabling
experimentalDecorators
and getI wondered if I would have any more success with
ember-decorators@6.0.0
but (without installing@ember-decorators/babel-transforms
I get theProperty value expected type of string but got null
error.Is there some combination of modules and compile flags that I should be using to get this to work.
The text was updated successfully, but these errors were encountered: