@sort deprecation message missing replacement code

[jacobq]

When I use a line like this in my Ember 3.9.0 app (w/ ember-decorators and ember-decorators-polyfill) I get a deprecation warning (expected) with apparently missing / incorrect instructions (unexpected).

import { mapBy, sort, uniq } from '@ember-decorators/object/computed';

[jacobq]

This seems to be coming from

ember-decorators/packages/object/addon/computed.js

Line 705 in 84414eb

export const sort = legacyMacroWithMethod(emberSort);

ember-decorators/packages/object/addon/-private/util.js

Line 65 in 84414eb

export function legacyMacroWithMethod(fn, required) {

ember-decorators/packages/object/addon/-private/util.js

Lines 116 to 120 in 84414eb

	return computedDecoratorWithRequiredParams((elementDesc, params) => {
	let method = getMethod(fn, elementDesc, params, required);
	return fn(...params, method);
	}, fn.name);

ember-decorators/packages/utils/addon/computed.js

Line 51 in 84414eb

`You are using @${name} decorator from ember-decorators. This decorator is deprecated, you can now use Ember's built in decorators directly. Install the ember-decorators-polyfill (https://github.com/pzuraq/ember-decorators-polyfill), and replace your imports with imports from Ember:\n\n \`${importDesc};\`\n\n`,

since the calling function didn't provide importDesc.

A band-aid could be to check that importDesc is truthy before displaying it in the template string so that at least undefined; doesn't appear as the suggested replacement code. Better, perhaps legacyMacroWithMethod could be updated to pass the needed information through.

[jacobq]

Is the suggested replacement code import { /* legacy macros here */ } from '@ember/object/computed';? The docs are either out of date or in disagreement with this as they show things like import { sort } from '@ember-decorators/object/computed';.
https://ember-decorators.github.io/ember-decorators/docs/api/modules/@ember-decorators/object/computed

[pzuraq]

Yup, basically all of these should be imported directly from Ember now. We’re working on the latest release, which will update the documentation and remove these methods.