Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide clear guidance regarding version of decorators-transforms to use #416

Open
mike-north opened this issue Mar 13, 2019 · 4 comments
Open
Labels
5.x Issues affecting the 5.x series docs

Comments

@mike-north
Copy link
Collaborator

As of this moment, the latest version of @ember-decorators/babel-transforms is 5.1.4 (stage-2) and the octane blueprint consumes version ^2 (stage-1).

Given that nearly all consumers of this library are unlikely to even know that multiple manifestations of decorators have been proposed, we need to provide some incredibly clear guidance and feedback around what to use.

Most consumers are likely to assume they should use the latest version of everything, and that will lead them down a problematic path in this case. I've tested this hypothesis w/ 4 developers and pointed them to the relevant documentation -- they all ended up getting into trouble and being unable to figure out where to look for solutions.

@buschtoens
Copy link
Collaborator

Fixed by #415? 😊

@rwjblue
Copy link
Contributor

rwjblue commented Mar 14, 2019

In addition to making it possible to know whats going on (#415 does a good job of that), I think we can do a better job of choosing the version of @ember-decorators/babel-transforms in the main ember-decorators blueprint. This will go a long way towards making the onboarding experience less error prone (but doesn't help the "dependency bot problem").

Specifically, I think we can detect the Ember version and if the EMBER_NATIVE_DECORATORS flag is enabled and change the version of @ember-decorators/babel-transforms to install here

name: '@ember-decorators/babel-transforms',
target: '^3.1.0'
});

@buschtoens
Copy link
Collaborator

buschtoens commented Mar 14, 2019

Couldn't we instead release a new version of @ember-decorators/babel-transforms, that actually supports both stage 1 and stage 2? The transform itself already does support both versions via { legacy: true } and we could default this setting to EMBER_NATIVE_DECORATORS.

@rwjblue
Copy link
Contributor

rwjblue commented Mar 14, 2019

Yep! Probably would work just fine...

@buschtoens buschtoens added 5.x Issues affecting the 5.x series docs labels Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.x Issues affecting the 5.x series docs
Projects
None yet
Development

No branches or pull requests

3 participants