Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verifying subjects with parenthesis requires escaping the parenthesis #83

Open
chadoh opened this issue Nov 25, 2011 · 2 comments
Open

Comments

@chadoh
Copy link

chadoh commented Nov 25, 2011

I had this step:

Then "roger@example.com" should receive an email with subject "Someone (hopefully you!) submitted for you!"

and, though I could p ActionMailer::Base.deliveries and see that there was such an email that had been sent, the step would not pass until I changed it to:

Then "roger@example.com" should receive an email with subject "Someone \(hopefully you!\) submitted for you!"

Which makes the feature look weird. I know email-spec is doing a regex match behind the scenes, which is very helpful, but since the subject is in quotes in this step, I think it would make sense to escape regex characters like parens.

Thanks for the wonderful gem and all the hard work you put into it!

@hammerdr
Copy link
Contributor

hammerdr commented Apr 4, 2012

You should probably just create your own step_definition for this that uses == instead of =~ in the RSpec matching.

@pichot
Copy link

pichot commented Nov 7, 2012

Looks like this is already fixed as of a23d1a6 and shoud be in 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants