Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Enhance RevokeSponsorshipOperation.Builder #297

Open
duckmatt opened this issue Jan 8, 2021 · 0 comments
Open

Enhance RevokeSponsorshipOperation.Builder #297

duckmatt opened this issue Jan 8, 2021 · 0 comments
Assignees

Comments

@duckmatt
Copy link
Contributor

duckmatt commented Jan 8, 2021

Is your feature request related to a problem? Please describe.

At the moment the revoke sponsorship operations are quite difficult to use, for example RevokeSponsorshipOperation.Builder only takes an xdr object (RevokeSponsorshipOp)

Describe the solution you'd like

Have an operation class for each of the different revoke sponsorship types:

image

This is the approach the Java sdk takes, for example they have the classes:

  • RevokeAccountSponsorshipOperation
  • RevokeClaimableBalanceSponsorshipOperation
  • RevokeDataSponsorshipOperation
  • RevokeOfferSponsorshipOperation
  • RevokeSignerSponsorshipOperation
  • RevokeTrustlineSponsorshipOperation

Describe alternatives you've considered

Enhance the existing builder to support the various attributes of a revoke sponsorship rather than take an xdr object

@duckmatt duckmatt changed the title Enhance Enhance RevokeSponsorshipOperation.Builder Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants