Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eLua pack.unpack does not check for sum overflows #106

Open
emilsedemil opened this issue Mar 22, 2017 · 0 comments
Open

eLua pack.unpack does not check for sum overflows #106

emilsedemil opened this issue Mar 22, 2017 · 0 comments

Comments

@emilsedemil
Copy link

In the UNPACKSTRING macro within lpack.c, the sum "i+m+l" is compared to "len" without checking that "i+m+l" does not overflow. A bad encoding could easily produce such overflow.

I would also suggest to rise an error instead of the current behavior of just "goto done"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant