Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add disableWhenSelectorFalsy prop in SharedProps rather than only TourProps #608

Open
pguduguntla opened this issue Nov 13, 2023 · 3 comments
Open

Add disableWhenSelectorFalsy prop in SharedProps rather than only TourProps #608

pguduguntla opened this issue Nov 13, 2023 · 3 comments

Comments

@pguduguntla
Copy link

Hi!

I am looking to use the disableWhenSelectorFalsy prop in the TourProvider. However, it is only a prop in TourProps as seen in the image. Is there a reason you are doing this? Would it be possible to move it SharedProps so it can be used by both components.

image
@elrumordelaluz
Copy link
Owner

Probably you are pretty right, mind making a PR?

@FranRom
Copy link

FranRom commented Dec 15, 2023

Was this done?

@SenyaMur
Copy link

Hi, when it will be fix ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@elrumordelaluz @SenyaMur @pguduguntla @FranRom